On Thu, Mar 20, 2025 at 3:25 PM Rushabh Lathia <rushabh.lat...@gmail.com> wrote: > > Hi Alvaro, > > Thank you for the offline discussion. > > As we all agree, changing the attnotnull datatype would not be a good idea > since it is > a commonly used catalog column, and many applications and extensions depend > on it. > > Attached is another version of the patch (WIP), where I have introduced a new > catalog column, > pg_attribute.attinvalidnotnull (boolean). This column will default to FALSE > but will be set to TRUE > when an INVALID NOT NULL constraint is created. With this approach, we can > avoid performing > extra scans on the catalog table to identify INVALID NOT NULL constraints, > ensuring there is no > performance impact. > > Also updated the pg_dump implementation patch and attaching the same here. >
These patches do not address comments discussed in [1]. Since there was a change in design, I am assuming that those will be addressed once the design change is accepted. [1] https://www.postgresql.org/message-id/202503121157.3zabg6m3anwp@alvherre.pgsql -- Best Wishes, Ashutosh Bapat
