While working on something else I noticed $SUBJECT: we are allocating more memory than necessary and copying more data than necessary because we specify the wrong PgStat_KindInfo member as the size argument for MemoryContextAlloc and memcpy. This could become problematic if snapshotting a very large number of variables stats, so I fixed it. Attached is a patch for that.
Best regards, Etsuro Fujita
fix-thinko-in-pgstat_build_snapshot.patch
Description: Binary data
