On Tue, Apr 1, 2025 at 11:25 PM Nathan Bossart <nathandboss...@gmail.com> wrote: > > On Tue, Apr 01, 2025 at 05:33:02PM +0700, John Naylor wrote: > > On Thu, Mar 27, 2025 at 2:55 AM Devulapalli, Raghuveer > > <raghuveer.devulapa...@intel.com> wrote:
> >> (2) Might be apt to rename pg_crc32c_sse42*.c to pg_crc32c_x86*.c since > >> they contain both sse42 and avx512 versions. > > > > The name is now not quite accurate, but it's not exactly misleading > > either. I'm leaning towards keeping it the same, so for now I've just > > updated the header comment. > > I'm not too worried about this one either. FWIW I'm likely going to look > into moving all the x86_64 popcount stuff into pg_popcount_avx512.c and > renaming it to pg_popcount_x86_64.c for v19. This would parallel > pg_popcount_aarch64.c a bit better, and a file per architecture seems like > a logical way to neatly organize things. Seems like a good idea. > I read through the code a couple of times and nothing stood out to me. Thanks for looking, I plan to commit this over the weekend unless there are objections. -- John Naylor Amazon Web Services
