On Sat, Mar 22, 2025 at 7:26 PM vignesh C <vignes...@gmail.com> wrote: > > Hi, > > Currently, error reports for database, publication, subscription, and > replication slots do not include the option name. This has been > addressed by including the option name in the error messages, ensuring > consistency similar to remove option. Additionally, pg_log_error and > exit(1) have been replaced with a single pg_fatal statement which > means the same. The attached patch implements these changes. >
A few comments: * pg_createsubscriber.exe -D ..\..\data_standby -d db1 -d db2 -d db1 --publication pub1 --publication pub1 -P "dbname=postgres port=5432" -p 5444 --dry-run pg_createsubscriber: error: database "db1" specified more than once for --database Even when user has used short form, we are displaying long form for database. I suggest to use both short and long form where applicable. * "invalid object type \"%s\" specified for --remove". Isn't it better to use the short form as well in this error message? -- With Regards, Amit Kapila.
