Dear Fujii-san,
> -is($node_primary->slot('dropme_slot')->{'slot_name'},
> - undef, 'logical slot was actually dropped on standby');
> +is($node_primary->slot('dropme_slot')->{'plugin'},
> + '', 'logical slot was actually dropped on standby');
>
> This seems like a separate issue from what your patch is addressing,
> but since this test is meant to confirm that the slot was dropped
> on the standby, shouldn't node_primary be node_replica instead?You are right. It has been missed 8 years ago, let's fix now. BTW, the issue exists for all supported branches. How do you feel to backpatch them? PSA all patch set. Best regards, Hayato Kuroda FUJITSU LIMITED
v2-PG13-0001-Fix-invalid-referring-of-hash-ref-for-replic.patch
Description: v2-PG13-0001-Fix-invalid-referring-of-hash-ref-for-replic.patch
v2-PG16-PG14-0001-Fix-invalid-referring-of-hash-ref-for-replic.patch
Description: v2-PG16-PG14-0001-Fix-invalid-referring-of-hash-ref-for-replic.patch
v2-master-PG17-0001-Fix-invalid-referring-of-hash-ref-for-replic.patch
Description: v2-master-PG17-0001-Fix-invalid-referring-of-hash-ref-for-replic.patch
