On Fri, Apr 11, 2025 at 4:02 AM Nazir Bilal Yavuz <byavu...@gmail.com> wrote: > I understand your point. I did it like that because bufferids start > from 1 and go to NBuffers inclusive in the pg_buffercache view, so it > seems more natural to me to implement it like that. I am okay to > replace these loops with [1] to make it standart everywhere: > > [1] > for (int buf = 0; buf < NBuffers; buf++) > { > BufferDesc *desc = GetBufferDescriptor(buf);
I'm more making an observation than asking for a change. If you and others think it should be changed, that is fine, but I'm uncertain myself what we ought to be doing here. I just wanted to raise the issue. -- Robert Haas EDB: http://www.enterprisedb.com