On 2025-04-13 Su 1:51 PM, Andres Freund wrote:
Hi,
On April 13, 2025 7:27:33 PM GMT+02:00, Wolfgang Walther
<walt...@technowledgy.de> wrote:
Andrew Dunstan:
On 2025-04-12 Sa 10:10 PM, Noah Misch wrote:
On Sat, Apr 12, 2025 at 07:51:06PM +0200, Wolfgang Walther wrote:
With injection points enabled, I get the following errors in test_aio:
[15:14:45.408](0.000s) not ok 187 - worker: first hard IO error is reported:
expected stderr
[15:14:45.409](0.000s)
[15:14:45.409](0.000s) # Failed test 'worker: first hard IO error is
reported: expected stderr'
# at t/001_aio.pl line 810.
[15:14:45.409](0.000s) # 'psql:<stdin>:88: ERROR: could
not read blocks 2..2 in file "base/5/16408": I/O error'
# doesn't match '(?^:ERROR:.*could not read blocks 2\.\.2 in file
\"base/.*\": Input/output error)'
It seems like it's just the error message that is different and has "I/O"
instead of "Input/output"?
Looks like it.
On a more general note, does enabling injection points make any sense here?
Yes, it does.
I see that coverage in the build farm is not very big. IIUC, those are a
development tool, so might not be relevant, because nobody is developing on
Alpine / musl?
No, whether anyone develops on the platform is not a factor. One hasn't fully
tested PostgreSQL until one builds with injection points.
Here's a simple fix ... also removes some unnecessary escaping and leaning
toothpick syndrome.
Confirmed - this works!
Thanks for testing and writing up a fix. Andrew, would you be ok applying it?
I've been traveling the last 24h and should probably not handing sharp commit
bits tonight.
I'm not too surprised about failures like this, when writing the tests up I was
worried about different formulations. But after seeing freebsd, glibc Linux,
netbsd, openbsd windows all working the same I thought we were in the clear.
pushed.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
