> On 16 Apr 2025, at 23:42, Tom Lane <t...@sss.pgh.pa.us> wrote: > It seems fairly dangerous to ignore -Wfree-nonheap-object warnings. > I feel like we ought to move to prevent these somehow.
Absolutely agree. > I'm not sure > how other than giving up on stack allocation of JsonLexContexts, > though, especially if we consider the jsonapi API frozen. But seeing > that there are only three such call sites and none of them seem in the > least performance-critical, maybe we should just do that? I can't see any other option really, and there is no performance angle really so that should be safe. Since I committed at least one of these, let me know if you want me to tackle it. -- Daniel Gustafsson