Dear Michael,
> > I also feel just converting lower case is not good. The point seems to
> > locate in
> > the end-of-transaction callback and it accepts invalidation messages. Based
> > on
> the
> > fact, how about "inval-process-invalidation-messages"?
> > 0002 did simple replacements of these words.
>
> - INJECTION_POINT("heap_update-before-pin");
> + INJECTION_POINT("heap-update-before-pin");
>
> The former name is better IMO. heap_update() is the name of the
> function where the point is defined.
>
> - INJECTION_POINT("AtEOXact_Inval-with-transInvalInfo");
> + INJECTION_POINT("inval-process-invalidation-messages");
>
> This naming has been puzzling me, though, so a rename looks fit. I am
> not sure that this is the best name that matches with this code path,
> as this lacks a reference regarding the end of a transaction. Perhaps
> something like "end-transaction-process-inval" would be better?Thanks for suggesting them. ISTM, you are correct. PSA updated version. Best regards, Hayato Kuroda FUJITSU LIMITED
v3-0001-Doc-clarify-the-naming-rule-for-injection-points.patch
Description: v3-0001-Doc-clarify-the-naming-rule-for-injection-points.patch
v3-0002-Follow-naming-rules-for-injection-points.patch
Description: v3-0002-Follow-naming-rules-for-injection-points.patch
