On Mon, Apr 21, 2025 at 11:46 AM Daniel Gustafsson <dan...@yesql.se> wrote: > We do, but with the current coding we call setJsonLexContextOwnsTokens > immediately after creation which derefences the pointer without checkinf for > allocation failure.
Right. (The flag does nothing on the OOM sentinel.) > This means we dereference the pointer before we can check > for an OOM return from pg_parse_json which even if safe seems to violate code > readability no? Personally, I'm fine with can't-fail APIs, as long as they're documented as such. (I think the deferred error API was probably chosen so that src/common JSON clients could be written without a lot of pain?) --Jacob
