On Mon, May 5, 2025 at 12:20:15PM -0700, Jacob Champion wrote: > On Thu, May 1, 2025 at 7:44 PM Bruce Momjian <br...@momjian.us> wrote: > > https://momjian.us/pgsql_docs/release-18.html > > > +Add support for the "oauth" authentication (Jacob Champion, Daniel > > Gustafsson, Thomas Munro) > > Should be either 'support for "oauth" authentication' or 'support for > the "oauth" authentication method', I think. Okay.
> > +This adds an "oauth" authentication method to pg_hba.conf, a server > > variable oauth_validator_libraries to specify OAUTH libraries, a configure > > flag --with-libcurl to add the required > > +compile-time libraries, and libpq OAUTH options. > > Maybe the description of oauth_validator_libraries could be something > like "to load token validation modules"? Done. > Also, "OAUTH" should just be "OAuth". We should probably lock in the > capitalization: > > - "OAuth" is the name of the framework we're using > - "oauth" is the HBA method name in the configs > - "OAUTHBEARER" is the internal name of the SASL method, which most > users don't care about and should only rarely appear in the docs Capitalization changed, patch attached. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future.
diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml index 2fda2b94964..9a6e4fb8d0e 100644 --- a/doc/src/sgml/release-18.sgml +++ b/doc/src/sgml/release-18.sgml @@ -1087,13 +1087,13 @@ Author: Daniel Gustafsson <dgustafs...@postgresql.org> <listitem> <para> -Add support for the "oauth" authentication (Jacob Champion, Daniel Gustafsson, Thomas Munro) +Add support for the OAuth authentication method (Jacob Champion, Daniel Gustafsson, Thomas Munro) <ulink url="&commit_baseurl;b3f0be788">§</ulink> </para> <para> -This adds an "oauth" authentication method to pg_hba.conf, a server variable oauth_validator_libraries to specify OAUTH libraries, a configure flag --with-libcurl to add the required -compile-time libraries, and libpq OAUTH options. +This adds an "oauth" authentication method to pg_hba.conf, libpq OAuth options, a server variable oauth_validator_libraries to load token validation libraries, and +a configure flag --with-libcurl to add the required compile-time libraries. </para> </listitem>
