On Sat, May 10, 2025 at 3:51 PM Greg Sabino Mullane <htamf...@gmail.com> wrote: > I may have missed something (we seem to have a lot of threads for this > subject), but we are in beta and both pg_dump and pg_upgrade seem to be > opt-out? I still object strongly to this; pg_dump is meant to be a canonical > representation of the schema and data. Adding metadata that can change from > dump to dump seems wrong, and should be opt-in. I've not been convinced > otherwise why stats should be output by default. > > To be clear, I 100% want it to be the default for pg_upgrade. > > Maybe we are just leaving it enabled to see if anyone complains in beta, but > I don't want us to forget about it. :)
Yeah. This could use comments from a few more people, but I really hope we don't ship the final release this way. We do have a "Enable statistics in pg_dump by default" item in the open items list under "Decisions to Recheck Mid-Beta", but that's arguably now. It also sort of looks like we might have a consensus anyway: Jeff said "I lean towards making it opt-in for pg_dump and opt-out for pg_upgrade" and I agree with that and it seems you do, too. So perhaps Jeff should make it so? -- Robert Haas EDB: http://www.enterprisedb.com
