On Wed, 2025-04-30 at 14:35 +0900, Michael Paquier wrote:
> - 0001 is a patch I have stolen from a different thread (see [1]),
> introducing InjectionPointList() that retrieves a list of the
> injection points attached.
Unless that other thread is blocked for some reason, I'd suggest just
going ahead with the SQL callable function first. That seems
independently useful.
> - 0002 extends injection_points with a new flush function, that can
> be
> used in TAP tests to persist some points across restarts. One sticky
> point is that I did not want to add any of this information in the
> core backend injection point APIs, nor to any of the backend
> structures because that's not necessary, and what's here is enough
> for
> some TAP tests.
This seems like a fair amount of complexity for a single use case.
Arguably, complexity around testing infrastructure is a lot less of a
problem than other kinds of complexity, so it might be OK. But it would
be nice if there were a couple cases that would benefit rather than
one.
Regards,
Jeff Davis
