Hackers, On May 26, 2025, at 18:00, David E. Wheeler <da...@justatheory.com> wrote:
> Yes, I think it would be best if the grammar was a bit stricter --- and > therefore more self-explanatory --- by making the args closer to what the > functions actually expect. I chatted with Florents and went ahead and simplified the grammar and fixed the other issues I identified in my original review. Note that there are two commits, now: `v6-0001-Rename-jsonpath-method-arg-tokens.patch` Renames some of the symbols in the jsonpath grammar so that they’re less generic (`csv*`) and more specific to their contents. This is with the expectation that they will be used by other methods in the next patch and in the future. I thought it best to separate this refactoring from the feature patch. `v6-0002-Add-additional-jsonpath-string-methods.patch` is that feature patch. The grammar now parses the exact number and types of each method argument, eliminating the need for explicit error checking. It also uses the existing patterns for handling methods with two parameters, removing a bunch of duplicate code. Overall I think this is ready for committer review, although now that I’m not just reviewing but hacking on this thing, maybe someone else should review it first. Patches attached, GitHub PR here: https://github.com/theory/postgres/pull/12 Best, David
v6-0001-Rename-jsonpath-method-arg-tokens.patch
Description: Binary data
v6-0002-Add-additional-jsonpath-string-methods.patch
Description: Binary data
signature.asc
Description: Message signed with OpenPGP
