On 04.06.25 11:56, Amit Kapila wrote:
It's not clear to me how this change now would substantially improve the
user experience. The number of characters you type is approximately the
same. You still need to support the old mode because the backup might
not come from pg_basebackup.
In the current functionality, the user must first manually create a
standby or use an existing standby to make it a subscriber. I thought
saving this step for users would be quite helpful. It also helps
streamline the process into a single, cohesive workflow.
Unless I'm missing something, doesn't this merely replace
pg_basebackup && pg_createsubscriber
with
pg_createsubscriber --create-standby
I mean, as I'm typing this out, this is literally the same number of
characters. Is the second one easier somehow? It's not clear.
And then you'd have the maintenance
overhead that every new feature in pg_basebackup would potentially have
to be passed through or somehow be integrated into pg_createsubscriber.
I am not so sure about this because we use other utilities like pg_ctl
in this tool, so same argument could be build for it.
Yes, and we tried really hard to avoid the dependency on pg_ctl, but it
was too hard. (I would entertain patches to get rid of it.)
