Hi, Thomas Munro off-list mentioned that the Windows CI image is actually running on Server 2022, even though the task name still refers to Server 2019. He also suggested upgrading the compiler from Visual Studio 2019 to Visual Studio 2022.
A PR [1] to upgrade the compiler to VS 2022 is ready in Andres' pg-vm-images repository (where the CI images are built). This VS 2022 image passes all tests for both MinGW [2] and Meson & Ninja [2]. Once it's merged, the CI images will automatically start using the VS 2022 compiler. Two patches are attached, the first one is for fixing server names and the second one is for upgrading the VS compiler version in the task name. Please note: the PR and second patch should be committed simultaneously to avoid mismatches (e.g., a VS 2019 task running with a VS 2022 compiler, or vice versa). Any feedback would be appreciated. [1] https://github.com/anarazel/pg-vm-images/pull/114 [2] https://cirrus-ci.com/build/5095727501672448 -- Regards, Nazir Bilal Yavuz Microsoft
From 8bb0ba7db2cd56cf8d459b90df3643a8ee31c346 Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz <byavu...@gmail.com> Date: Thu, 5 Jun 2025 10:29:06 +0300 Subject: [PATCH 1/2] ci: Update Windows task names to reflect Server 2022 The Windows CI image has been running on Server 2022 for some time, but task names still referred to Server 2019. Reported-by: Thomas Munro <thomas.mu...@gmail.com> --- .cirrus.tasks.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.cirrus.tasks.yml b/.cirrus.tasks.yml index 92057006c93..0616cb71a00 100644 --- a/.cirrus.tasks.yml +++ b/.cirrus.tasks.yml @@ -701,7 +701,7 @@ WINDOWS_ENVIRONMENT_BASE: &WINDOWS_ENVIRONMENT_BASE task: - name: Windows - Server 2019, VS 2019 - Meson & ninja + name: Windows - Server 2022, VS 2019 - Meson & ninja << : *WINDOWS_ENVIRONMENT_BASE env: @@ -753,7 +753,7 @@ task: task: << : *WINDOWS_ENVIRONMENT_BASE - name: Windows - Server 2019, MinGW64 - Meson + name: Windows - Server 2022, MinGW64 - Meson # due to resource constraints we don't run this task by default for now trigger_type: manual -- 2.49.0
From f9b789fa128f8cd3c39550a81659bb3e0aa9440e Mon Sep 17 00:00:00 2001 From: Nazir Bilal Yavuz <byavu...@gmail.com> Date: Thu, 5 Jun 2025 10:31:37 +0300 Subject: [PATCH 2/2] ci: Update Windows task name to reflect VS 2022 With the compiler being upgraded to Visual Studio 2022 (see related PR [1]), update the task name to accurately describe the environment. [1] https://github.com/anarazel/pg-vm-images/pull/114 Suggested-by: Thomas Munro <thomas.mu...@gmail.com> --- .cirrus.tasks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.cirrus.tasks.yml b/.cirrus.tasks.yml index 0616cb71a00..d6dfa52e4cf 100644 --- a/.cirrus.tasks.yml +++ b/.cirrus.tasks.yml @@ -701,7 +701,7 @@ WINDOWS_ENVIRONMENT_BASE: &WINDOWS_ENVIRONMENT_BASE task: - name: Windows - Server 2022, VS 2019 - Meson & ninja + name: Windows - Server 2022, VS 2022 - Meson & ninja << : *WINDOWS_ENVIRONMENT_BASE env: -- 2.49.0
