On Mon, Jun 9, 2025 at 9:45 AM Dilip Kumar <dilipbal...@gmail.com> wrote: > I was reviewing the code for conflict reporting and became curious > about the choice of ERRCODE_T_R_SERIALIZATION_FAILURE. This error code > typically signifies a serialization failure within a transaction under > serializable isolation, so its use here for a different type of > conflict seems somewhat out of place. I did notice its use in other > contexts for recovery conflicts in physical replication, which also > struck me as a bit unusual. > > Given these observations, I'm wondering if it would be more > appropriate to introduce a new, more specific error code for this > purpose?
Makes sense to me. I'm not sure if we should use a new error code or some other existing one, but conflating other things with serializable failures seems like a bad plan. -- Robert Haas EDB: http://www.enterprisedb.com