> I'm not quite following your uneasiness with the tranche names. For the > dshash table, we'll need a tranche for the DSA and one for the hash table, > so presumably any wait events for those locks should be named accordingly, > right?
I may be alone in this opinion, but I prefer the suffixless tranche name for the primary LWLock (the hash table), as this is the lock users will encounter most frequently in wait events, like when adding or looking up entries. Adding a suffix (e.g., "Hash") may be confusing to the extension. In the tests that I did with pg_stat_statements, I’d rather see "pg_stat_statements" remain as-is, rather than "pg_stat_statements Hash". On the other hand, adding a suffix to the DSA tranche name (e.g., "pg_stat_statements DSA") is necessary to differentiate it from the Hash tranche name, and that is OK because it's not likely to be a user-visible wait event. -- Sami
