On 2025/06/11 5:33, Nathan Bossart wrote:
On Tue, Jun 10, 2025 at 12:37:48PM -0700, Masahiko Sawada wrote:
(1) adds tab completion support for the REJECT_LIMIT option, which was
introduced in v18
(2) splits the tab completion logic between COPY FROM and COPY TO to
reflect their different options.
[...]
Given REJECT_LIMIT is a new v18 feature, it seems to me that (1) is an
oversight of this feature, but I also agree that it's not a bug and
doesn't block the release.
How does the RMT feel about the change (1)? Nathan, would you be OK with that?
0001 sure seems like an oversight in commit 4ac2a9b to me. In any case, I
argued that we should fix tab completion for unlogged partitioned tables in
v18 [0], and this seems pretty similar.
BTW, I also have a similar patch [1] in my queue that I'm planning to commit.
Materialized views have been allowed in COPY TO since v18 (commit 534874fac0b),
and that patch improves tab completion to include them. For the same reason
discussed here, it might make sense to commit that patch in v18 as well.
Regards,
[1]
https://postgr.es/m/cacjufxfxnskikp+gormaghcmtx1yh2hrxw1+3djm9w7yy9h...@mail.gmail.com
--
Fujii Masao
NTT DATA Japan Corporation
