Hi Ashutosh, On Wed, Jun 11, 2025 at 7:11 PM Ashutosh Bapat <ashutosh.bapat....@gmail.com> wrote: > > > > On Wed, Jun 11, 2025 at 5:12 AM Junwang Zhao <zhjw...@gmail.com> wrote: >> >> Hi Nathan, >> >> On Wed, Jun 11, 2025 at 12:30 AM Nathan Bossart >> <nathandboss...@gmail.com> wrote: >> > >> > On Wed, Jun 11, 2025 at 12:07:35AM +0800, Junwang Zhao wrote: >> > > All other files perform this check using RELATION_IS_OTHER_TEMP. >> > > Should we update tablecmds.c to do the same for consistency? >> > >> > Seems like a good idea. >> >> Thanks for the comment. >> >> I have attached a patch with the proposed changes. > > > LGTM. I looked at other instances of is_localtemp, but none of them have > (relation)->rd_rel->relpersistence == RELPERSISTENCE_TEMP there. Your patch > has covered all the existing ones.
Thank you for the review and the additional check. I have created a cf entry to track this. https://commitfest.postgresql.org/patch/5815/ > > -- > Best Wishes, > Ashutosh Bapat -- Regards Junwang Zhao
