On 07.04.25 21:15, Masahiko Sawada wrote:
On Sun, Apr 6, 2025 at 7:19 PM Zhijie Hou (Fujitsu)
<houzj.f...@fujitsu.com> wrote:

On Sat, Apr 5, 2025 at 1:45 AM Masahiko Sawada wrote:

Hi,

Thank you for updating the patch! Pushed with small cosmetic changes.

Thanks for pushing the feature !

I noticed one typo in the doc and here is a tiny patch to fix it.

-        The <option>--two-phase</option> and <option>--falover</option> options
+        The <option>--two-phase</option> and <option>--failover</option> 
options

Thank you for the report and the patch! Pushed.

I wonder if the option name --failover is ideal. To me, it sounds like an action "do a failover!". Also consider that pg_recvlogical has other action options such as --start and --create-slot, so it sounds a bit like those.

Maybe something like --enable-failover would be better?



Reply via email to