On Mon, Jun 23, 2025 at 08:48:35AM +0900, Michael Paquier wrote: > Anyway, here is an attempt at leaning all that. I am really tempted > to add a couple of const markers to force VacuumParams to be in > read-only mode, even if it means doing so for vacuum() but not touch > at vacuum_rel() where we double-check the reloptions for the truncate > and index cleanup options. That would be of course v19-only material. > Thoughts or opinions?
Is the idea to do something like this for v19 and this [0] for the back-branches? I think the recurse-to-TOAST-table case is still broken with your patch. We should probably move the memcpy() for toast_vacuum_params to the very top of vacuum_rel(). Otherwise, your patch looks generally reasonable to me. [0] https://postgr.es/m/aFRzYhOTZcRgKPLu%40nathan -- nathan
