On Fri, 11 Apr 2025 at 20:17, Nathan Bossart <nathandboss...@gmail.com> wrote: > > On Thu, Apr 10, 2025 at 11:58:41PM +0530, Mahendra Singh Thalor wrote: > > As per above discussions, for v18, we will not do any change to server > > side to fix the issue of \n\r in database names. But as a cleanup > > patch, we can give an alert to the user by "pg_upgrade --check". As > > per current code, pg_dump and pg_upgrade will fail with "shell > > command" error but in the attached patch, we will give some extra info > > to the user by "pg_upgrade --check" so that they can fix database > > names before trying to upgrade. > > > > Here, I am attaching a patch which will give a list of invalid > > database names in "pg_upgrade --check". We can consider this as a > > cleanup patch. > > Are you proposing this for v18? I think this is all v19 material at this > point. Perhaps we could argue this is a bug fix that should be > back-patched, but IMHO that's a bit of a stretch. I don't sense a > tremendous amount of urgency, either. > > -- > nathan
Thanks Nathan for the review. I want to re-start this thread for v19. I posted v06* patches in my previous updates[1]. Please someone review it and let me know feedback. v06 patches: v06_patches <https://www.postgresql.org/message-id/CAKYtNAqC5pkjmh8UgvbNLtMyEVeKUtDF3_%2B9dvG9zb8YrhTJQQ%40mail.gmail.com> [1] : https://www.postgresql.org/message-id/CAKYtNAqC5pkjmh8UgvbNLtMyEVeKUtDF3_%2B9dvG9zb8YrhTJQQ%40mail.gmail.com -- Thanks and Regards Mahendra Singh Thalor EnterpriseDB: http://www.enterprisedb.com
