On Wed, Jun 25, 2025 at 07:47:27AM +0000, Andy Fan wrote: > When I am reading the code, I first thought I can do something in > HeapTupleheaderSetXminCommitted, then I realized we have SetHintBits. > After some research, I find HeapTupleHeaderSetXminCommitted is never > used and it looks not safe to use after comparing with SetHintBits. So > to avoid future confusion or misuse, I'd suggest to remove it. I think > HeapTupleHeaderSetXminInvalid should be the same. So here is the patch.
There is a cost in removing such code, even if not used in core: extension code outside of core may use it, and they would fail to compile. This can break code, and keeping them around has no maintenance cost. -- Michael
signature.asc
Description: PGP signature
