On 23.06.25 05:48, Hayato Kuroda (Fujitsu) wrote:
Thanks for posting the patch. Largely it seems OK.
Thanks, I have committed this.
One comment:
I feel most of the word "remove" can be changed to "dropped", in
pg_createsubscriber.c
and 040_pg_createsubscriber.pl. E.g.,
```
# Confirm the physical replication slot has been removed
$result = $node_p->safe_psql($db1,
"SELECT count(*) FROM pg_replication_slots WHERE slot_name =
'$slotname'"
);
is($result, qq(0),
'the physical replication slot used as primary_slot_name has been
removed'
);
```
And
```
/* Remove failover replication slots if they exist on subscriber */
drop_failover_replication_slots(dbinfos.dbinfo);
```
These are from areas unrelated to this patch or the original patch that
introduced this feature, so it felt out of scope to touch those at this
point. I don't feel strongly about the need to wipe out all uses of the
word "remove". It's okay to be a bit flexible in code comments and
other less prominent places, I think.
