On Fri, 27 Jun 2025 14:06:24 +0900 ikedarintarof <ikedarinta...@oss.nttdata.com> wrote:
> Hi, > > Thank you very much for your valuable comments and kind advice. I'm > currently working on revising the previous patch based on the feedback > received. I would like to share my thoughts regarding the conditions > under which the --continue-on-error option should initiate a new > transaction or a new connection. > > In my opinion, when the --continue-on-error option is enabled, pgbench > clients does not need to start new transactions after network errors and > other errors except for SQL-level errors. +1 I agree that --continue-on-error prevents pgbench from terminating only when SQL-level errors occur, and does not change the behavior in the case of other types of errors, including network errors. > > As I understand it, the proposed --continue-on-error option does not > > retry the transaction > > in any case; it simply gives up on the transaction. That is, when an > > SQL-level error occurs, > > the transaction is reported as "failed" rather than "retried", and the > > random state is discarded. > > Retrying the failed transaction is not necessary when the transaction > failed due to SQL-level errors. Unlike real-world applications, pgbench > does not need to complete specific transaction successfully. In the case > of unique constraint violations, retrying the same transaction will > likely to result in the same error again. Agreed. Regards, Yugo Nagata -- Yugo Nagata <nag...@sraoss.co.jp>
