Andres Freund <and...@anarazel.de> wrote: > On 2025-03-13 11:53:03 +0100, Antonin Houska wrote: > > Attached are a few proposals for minor comment fixes. > > Thanks, applied.
After reading the code a bit more, I noticed that the 'cb_flags' argument of PgAioHandleCallbackStage is not really used, at least in the existing callbacks. Is there an intention to use it in the future (the patches for async write do not seem to indicate so), or is this only a leftover from previous versions of the patch? Besides that, I suggest a minor comment fix. -- Antonin Houska Web: https://www.cybertec-postgresql.com
diff --git a/src/include/storage/aio_types.h b/src/include/storage/aio_types.h index 18183366077..afee85c787b 100644 --- a/src/include/storage/aio_types.h +++ b/src/include/storage/aio_types.h @@ -107,7 +107,7 @@ typedef struct PgAioResult /* of type PgAioResultStatus, see above */ uint32 status:PGAIO_RESULT_STATUS_BITS; - /* meaning defined by callback->error */ + /* meaning defined by callback->report */ uint32 error_data:PGAIO_RESULT_ERROR_BITS; int32 result;
