"David E. Wheeler" <da...@justatheory.com> writes:
> For those who didn’t click through, that post has a screenshot of an
> ABI diff report in the build farm server that I think is worth
> seeing:
Nitpick: I think something is backwards about the labeling. AFAICS
the described ABI change was made by 53cd0b71e not its predecessor
9dcc76414. It does look like a useful bit of information once
correctly attributed, though.
> Mankirat and I have been discussing whether the project needs to
> diff every commit since the last time it was run (or from the root
> commit of the branch) or just the most recent. I’m leaning toward
> the latter, as it’s more like how other stuff in the build farm
> client works. But it also seems useful to report on individual
> commits (as in this one committed by Tom). Thoughts?
What we are going to want to know is if there are any ABI breaks in a
stable branch since the last release point. Once something turns up
in that view, it'd be good to be able to drill down to exactly which
commit(s) caused the changes. But nobody is going to want to leaf
through dozens or hundreds of per-commit reports, most of which should
be totally uninteresting for this purpose (in a back branch anyway).
Also, assuming we take action to undo the break, the cancelling-out
commits are no longer interesting, but we want to ensure that indeed
the ABI break is gone. So in my mind, ABI diff between last release
and branch tip is going to be the normal thing to want to see.
regards, tom lane
