Nathan Bossart <nathandboss...@gmail.com> writes: > Here is what I have staged for commit, which (barring feedback or > objections) I am planning to do towards the end of the week.
Is it intentional that this does +#include "catalog/pg_largeobject_metadata.h" +#include "catalog/pg_shdepend.h" rather than including the corresponding *_d.h headers? If so, why? Our normal coding convention is that frontend code should only include catalog *_d.h files, since the main headers might contain frontend-unfriendly declarations. If there is something we need to expose in these catalogs' *_d.h headers, we should probably do that. regards, tom lane