Hi, On Sat, 19 Jul 2025 at 09:06, Michael Paquier <mich...@paquier.xyz> wrote: > > This one looks acceptable to me, so applied to begin with something, > splitting things into two pieces for clarity with some tweaks. I have > changed things to use system_log() at the end, with fat-commas to link > the long options and their arguments.
Thanks! I realized that we actually don't trim the file, we do the opposite; read the file from both ends. Sorry for not realizing earlier. I will update the remaining patches according to that but I think trim_file() is helpful, too. What do you think about adding both ``` trim_file() -> trims $n lines from head or tail of the file and returns the remaining lines. read_file_ends() -> returns $n lines from head or tail of the file. ``` although trim_file() will not be used in these particular patches? -- Regards, Nazir Bilal Yavuz Microsoft
