On Tue, Jul 22, 2025 at 02:25:13PM -0500, Nathan Bossart wrote: > I stared at this patch some more and came up with the attached. The > biggest change is that I've moved the list of built-in LWLock tranches to > the existing lwlocklist.h file. That simplifies the patch and centralizes > these lists. This is arguably a bit too much preprocessor magic, though. > Thoughts?
With the argument about checking the consistency of the data between wait_event_names.txt, that looks like an improvement to me. And as far as I can see, the check you are adding in generate-lwlocknames.pl also makes sure that the ordering of the entries is correct. In short, I side with the argument that this extra magic will save cycles overall. -- Michael
signature.asc
Description: PGP signature