On Tue, Aug 12, 2025 at 6:25 PM Japin Li <japi...@hotmail.com> wrote: > I believe that the format %X-%X also works with sscanf(). However, to maintain > consistency, the format for sscanf() has been updated as well.
Yes. Thanks for the patch! Since we're changing the first "%X" in "%X-%X" to "%08X", the example file names in the docs should be updated too. For example: $ git grep "\.snap" | grep pglogicalinspect.sgml doc/src/sgml/pglogicalinspect.sgml:name | 0-40796E18.snap doc/src/sgml/pglogicalinspect.sgml:postgres=# SELECT * FROM pg_get_logical_snapshot_meta('0-40796E18.snap'); doc/src/sgml/pglogicalinspect.sgml:name | 0-40796E18.snap doc/src/sgml/pglogicalinspect.sgml:name | 0-40796E18.snap doc/src/sgml/pglogicalinspect.sgml:postgres=# SELECT * FROM pg_get_logical_snapshot_info('0-40796E18.snap'); doc/src/sgml/pglogicalinspect.sgml:name | 0-40796E18.snap I also noticed that the regression tests for pg_logicalinspect use file names in the old format. This doesn't cause test failures, but should we update them to match the new format? ... contrib/pg_logicalinspect/sql/pg_logicalinspect.sql:SELECT pg_get_logical_snapshot_info('0/40796E18.snap'); contrib/pg_logicalinspect/sql/pg_logicalinspect.sql:SELECT pg_get_logical_snapshot_info('../snapshots/0-40796E18.snap'); contrib/pg_logicalinspect/sql/pg_logicalinspect.sql:SELECT pg_get_logical_snapshot_meta('0-40796E18.foo.snap'); contrib/pg_logicalinspect/sql/pg_logicalinspect.sql:SELECT pg_get_logical_snapshot_meta('0/40796E18.snap'); ... Regards, -- Fujii Masao