Dear Tom, Thanks for the analysis.
> Based on this, I think we should remove the HASH_DEBUG support. > It's been broken for six of the last nine years and only one > person ever noticed. Moreover, if you were trying to find a > problem in dynahash, you'd probably want different debug logging > than what's here. I didn't realize that it has been broken for a long time. Agreed to remove the HASH_DEBUG option. > There might be a case for removing HASH_STATISTICS too, but > it seems weaker. I do recall having made use of that code > once years ago ... I have never used both options, but one point is that hash_stats() has been exported and extensions have called it. Is there a possibility that hidden developer is using? Anyway, I have no strong opinion. Attached patch does 1) remove HASH_DEBUG and 2) fix broken code with HASH_STATISTICS. Best regards, Hayato Kuroda FUJITSU LIMITED
v2-0001-Remove-HASH_DEBUG.patch
Description: v2-0001-Remove-HASH_DEBUG.patch
v2-0002-Fix-broken-code-for-HASH_STATISTICS.patch
Description: v2-0002-Fix-broken-code-for-HASH_STATISTICS.patch
