On Mon, Aug 18, 2025 at 1:36 PM Chao Li <[email protected]> wrote: > I think that patch could be separate, because the makefile changes are > generic to all map files. The current GB18030 patch doesn't depend on that > makefile patch at all. The makefile patch just makes build a little bit > easier upon map file changes.
I verified that both autoconf and meson builds pick up the change with these two patches, and the new test passes. I'm still not sure what circumstances you found where a change doesn't get picked up, but we can come back to that later if need be. BTW, the Commitfest shows these patches as "needs rebase". The reason for that is the naming. Commands like `git am` apply a series in order, and expects to find something like v3-0001-* v3-0002-* Your last attachment was v1-0001-* v2-0001-* ...and confusingly v2 needed to be applied first. To create a series from a branch, use `git format-patch master -v <version number>` and it will output an ordered series with one patch per commit. -- John Naylor Amazon Web Services
