On Mon, Aug 18, 2025 at 09:58:28AM -0400, Andres Freund wrote: > On 2025-08-18 08:57:13 +0900, Michael Paquier wrote: >> and it does not strike me as a good idea to begin doing that in the main >> isolation test suite, so perhaps the best thing to do here is just move this >> test to contrib/btree_gist/? > > No, it makes absolutely no sense to test e.g. hash killtuples support in > btree_gist.
Okay, then let's make sure that the build rules install it automatically if one runs only the isolation tests :) We do that everywhere else for other test suites with EXTRA_INSTALL. Being able to use make check is much more developer-friendly than requiring developers to use installcheck + a custom step to make sure that the module is installed in the instance running the tests. make check has worked for years when run independently in src/test/isolation/, and I do quite a bit of concurrency testing myself over time when working on a specific step of a larger implementation. I am pretty sure to not be the only one doing that. > What are you trying to say here? I've quickly looked at the possibility of *not* relying on btree_gist in this test, and also quickly concluded that you have made this choice to keep the test faster and easier to understand. That's fine. -- Michael
signature.asc
Description: PGP signature
