> On Aug 20, 2025, at 16:41, Shlok Kyal <[email protected]> wrote: > > Hi, > > While working on the thread [1]. We encountered that in the > 'AlterPublicationTables' function, the assignment 'isnull = true' is > redundant. This assignment is not required, and the variable will be > reassigned before use. > I have attached a patch to address this. > > [1]: > https://www.postgresql.org/message-id/CALdSSPgiDj8S8POf_6kiUkVrt9-EqYmn%2B2ahDqpdBpyteeAz-Q%40mail.gmail.com > > Thanks, > Shlok Kyal > <v1-0001-Remove-redundant-assignment-of-isnull-variable.patch>
If we look into the subsequent functions, yes, “isnull” will always be assigned. But how about if someone incidentally changed a subsequent function and moved an assignment? I think giving an initial value is a good habit without much performance burden. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
