Hi, On Tue, 26 Aug 2025 at 02:37, Jacob Champion <[email protected]> wrote: > > On Mon, Jul 28, 2025 at 11:20 AM Jacob Champion > <[email protected]> wrote: > > Sounds good. I will take another look at this with a committer hat and > > push Sometime Soon. > > Getting back to this -- for v7 I've rebased over the FASTLINK commit. > I've squashed 0002 and 0003 together, too -- I think it's easier to > see the new envvar hierarchy in one commit. > > I also moved the `-Dnls=disabled` setting into a mingw-specific > MESON_FEATURES variable. I think the existing comment in v6 wasn't > really in a place to prevent a developer from adding it to > MESON_COMMON_FEATURES in the future, which would have regressed > 967db242c. There shouldn't be a hazard now.
Thank you for doing these! Patches LGTM. I also checked the CI tasks and everything looks good. -- Regards, Nazir Bilal Yavuz Microsoft
