On 29/08/2025 11:12, Chao Li wrote:
On Aug 26, 2025, at 22:17, Damien Clochard <dam...@dalibo.info> wrote:
Le 25.08.2025 15:33, Greg Sabino Mullane a écrit :
Your v3 did not get attached to the previous email.
My bad, here it is
--
Damien
Clochard<v3-0001-Generate-random-dates-times-in-a-specified-range.patch>
Code change looks good to me. Maybe we can make
check_range_boundaries() “inline” as well.
But a major problem is, I think we should bump CATALOG_VERSION_NO.
Otherwise, running your code with an existing database, the new
functions won’t work.
Traditionally, the patch committer bumps the catversion, not the patch
author.
--
Vik Fearing
