On Sat, Aug 30, 2025 at 02:17:15PM -0400, Tom Lane wrote: > I wrote: > > If we're okay with items not having credits, then > > add_commit_links.pl's logic for where to put the <ulink>s needs > > improvement. I don't really understand why it's looking for > > parens in the first place -- why isn't the rule simply "put them > > before the first </para> in the item"? > > I revised the script to do it that way, as attached. The results > don't change in any of our stable branches. In v18, it makes > this change: > > diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml > index c3e318dab00..c49eb2655eb 100644 > --- a/doc/src/sgml/release-18.sgml > +++ b/doc/src/sgml/release-18.sgml > @@ -284,7 +284,7 @@ Author: Peter Eisentraut <pe...@eisentraut.org> > database clusters using pg_upgrade, it is recommended to reindex all > indexes related to full-text search and pg_trgm after the upgrade. > > - <ulink url="&commit_baseurl;fb1a18810f0">§</ulink> > +<ulink url="&commit_baseurl;fb1a18810f0">§</ulink> > </para> > </listitem> > > because of the blank line before the </para>, which is not our usual > style and should be removed IMO. (Alternatively, we could change > the $prev_leading_space updating logic to ignore blank lines.)
I ran our existing script against all the release notes back to PG 13 and saw no change if we removed the parenthesis check. However, the check also caught the missing attribution so I am inclined now to change the script, unless you can explain why we would want to skip the check. Thanks. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future.
