On Thu, Sep 04, 2025 at 12:30:27PM -0500, Sami Imseih wrote: > I liked removing the repalloc calls inside this routine and did not think > it was worth optimizing. I am OK with reverting it back. Although v1 > is incorrect since it's still initializing > NamedLWLockTrancheRequestArray to MAX_NAMED_TRANCHES
Committed with that fix. >> Furthermore, the >> MAX_NAMED_TRANCHES check isn't actually needed because InitializeLWLocks() >> will do the same check via its calls to LWLockNewTrancheId() for all the >> named tranche requests. > > I thought about that one and decided to add the error message there, since > requesting a tranche happens way before LWLockNewTrancheId is called > during CreateLWLocks, so it was more about erroring out slightly earlier. > But it may be ok to also just remove it. We needed it before because the array could only ever hold MAX_NAMED_TRANCHES requests. -- nathan
