On Mon, Sep 15, 2025 at 1:07 PM Zhijie Hou (Fujitsu) <houzj.f...@fujitsu.com> wrote: > > Thanks, the changes look good to me. I have merged them in V75 patch. >
Pushed. I see a BF which is not related with this commit but a previous commit for the work in this thread. See LOGs [1]: regress_log_035_conflicts ----------------------------------- [11:16:47.604](0.015s) not ok 24 - the deleted column is removed [11:16:47.605](0.002s) # Failed test 'the deleted column is removed' # at /home/bf/bf-build/kestrel/HEAD/pgsql/src/test/subscription/t/035_conflicts.pl line 562. Then the corresponding subscriber LOG: 025-09-15 11:16:47.600 CEST [1888170][client backend][1/13:0] INFO: vacuuming "postgres.public.tab" 2025-09-15 11:16:47.600 CEST [1888170][client backend][1/13:0] INFO: finished vacuuming "postgres.public.tab": index scans: 0 pages: 0 removed, 1 remain, 1 scanned (100.00% of total), 0 eagerly scanned tuples: 0 removed, 1 remain, 0 are dead but not yet removable tuples missed: 1 dead from 1 pages not removed due to cleanup lock contention removable cutoff: 787, which was 0 XIDs old when operation ended ... This indicates that the Vacuum is not able to remove the row even after the slot is advanced because some other background process holds a lock/pin on the page. I think that is possible because the page was dirty due to apply of update operation and bgwriter/checkpointer could try to write such a page. I'll analyze more tomorrow and share if I have any new findings. [1]: https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=kestrel&dt=2025-09-15%2009%3A08%3A07&stg=subscription-check -- With Regards, Amit Kapila.
