From 6ebbe9b27b52446438148a875e830857ea504813 Mon Sep 17 00:00:00 2001 From: Zhijie Hou Date: Tue, 16 Sep 2025 11:24:20 +0800 Subject: [PATCH v1] Stablize the tests in 035_conflicts The test used VACUUM to remove delete column, while that might not be stable due to concurrent bgwriter or checkpoint that would lock the page where the deleted tuple exists. Since the test has already confirmed that the replication slot.xmin has advanced, which should be sufficient to prove that the feature works correctly. This commit removes these unstable VACUUM tests. --- src/test/subscription/t/035_conflicts.pl | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/src/test/subscription/t/035_conflicts.pl b/src/test/subscription/t/035_conflicts.pl index f2aee0f70df..e1eb468991c 100644 --- a/src/test/subscription/t/035_conflicts.pl +++ b/src/test/subscription/t/035_conflicts.pl @@ -342,15 +342,6 @@ ok( $node_A->poll_query_until( ), "the xmin value of slot 'pg_conflict_detection' is updated on Node A"); -# Confirm that the dead tuple can be removed now -($cmdret, $stdout, $stderr) = $node_A->psql( - 'postgres', qq(VACUUM (verbose) public.tab;) -); - -ok( $stderr =~ - qr/1 removed, 1 remain, 0 are dead but not yet removable/, - 'the deleted column is removed'); - ############################################################################### # Ensure that the deleted tuple needed to detect an update_deleted conflict is # accessible via a sequential table scan. @@ -555,13 +546,6 @@ if ($injection_points_supported != 0) "the xmin value of slot 'pg_conflict_detection' is updated on subscriber" ); - # Confirm that the dead tuple can be removed now - ($cmdret, $stdout, $stderr) = - $node_A->psql('postgres', qq(VACUUM (verbose) public.tab;)); - - ok($stderr =~ qr/1 removed, 0 remain, 0 are dead but not yet removable/, - 'the deleted column is removed'); - # Get the commit timestamp for the publisher's update my $pub_ts = $node_B->safe_psql('postgres', "SELECT pg_xact_commit_timestamp(xmin) from tab where a=1;"); -- 2.51.0.windows.1