Hello, Alyona!

On Mon, Sep 8, 2025 at 8:35 AM Alyona Vinter <[email protected]> wrote:
>
> Sorry, wrong patches again. Here are the correct ones.

I went though this patches.
1) I've removed the array of parameters.  I see it was proposed by
Michael upthread.  But I think his proposal came from the fact we walk
trough the parameters twice.  But we end up walking trough the
parameter once in setup_recovery(), while reset_recovery_params() just
restores the previous contents.  I think it makes sense to keep the
changes minimal.
2) I reordered patches so that helper function goes first.  I think it
essential to order commit in the way that every commit leaves our tree
in working state.
3) I make pgpreltidy run over  040_pg_createsubscriber.pl.
Any thought?

------
Regards,
Alexander Korotkov
Supabase

Attachment: v4-0001-Implements-helper-function-in-recovery_gen.patch
Description: Binary data

Attachment: v4-0002-Reseting-recovery-target-parameters-in-pg_creates.patch
Description: Binary data

Reply via email to