On Tue, 16 Sept 2025 at 05:42, Sophie Alpert <[email protected]> wrote: > Thanks, this seems sensible given the reality that rescan happens once per > tuple. The `if (node->tss_TidList == NULL)` check you kept from me seems > likewise pointless in v3-0001 but not particularly intrusive (though of > course you use it in v3-0002).
That was a defensive coding choice. It could have been an Assert(node->tss_TidList == NULL);, but I just prefer it as an "if". > Otherwise v3-0001 lgtm. (I also took a look at v3-0002 and don't see any > immediate issues, though neither would I really consider myself qualified to > review it.) Thanks for looking, and for the report and patches. I've pushed and backpatched the fixes. v13 doesn't have TID Range Scans, so I opted to break the fix into 2 parts and apply to the relevant branches to try and keep the commit messages as accurate as possible. David
