Dear Amit, Vitaly, > I was thinking some more about this solution. Won't it lead to the > same problem if ReplicationSlotReserveWal() calls > ReplicationSlotsComputeRequiredLSN() after the above calculation of > checkpointer?
Exactly. I verified that in your patch, the invalidation can still happen if we cannot finish the LSN computation before the KeepLogSegments(). Attached file can be applied atop 0001-Fix-invalidation-... and v2-17-0001-Newly-created-replication... patches. It could invalidate the given slot. Best regards, Hayato Kuroda FUJITSU LIMITED
0001-Stop-using-injection_points-for-checkpointer.patch
Description: 0001-Stop-using-injection_points-for-checkpointer.patch
