On Wed, Sep 24, 2025 at 5:28 PM Ashutosh Bapat <ashutosh.bapat....@gmail.com> wrote: > > On Wed, Sep 24, 2025 at 2:38 PM shveta malik <shveta.ma...@gmail.com> wrote: > > > > On Wed, Sep 24, 2025 at 12:47 PM Ashutosh Bapat > > <ashutosh.bapat....@gmail.com> wrote: > > > > > > On Wed, Sep 24, 2025 at 10:12 AM shveta malik <shveta.ma...@gmail.com> > > > wrote: > > > > > > > > I tested the flows with > > > > a) logical replication slot and get-changes. > > > > b) filtered data flows: pub-sub creation with row_filters, 'publish' > > > > options. I tried to verify plugin fields as compared to total_wal* > > > > fields. > > > > c) reset flow. > > > > > > > > While tests for a and c are present already. I don't see tests for b > > > > anywhere when it comes to stats. Do you think we shall add a test for > > > > filtered data using row-filter somewhere? > > > > > > Added a test in 028_row_filter. Please find it in the attached > > > patchset. > > > > Test looks good. > > Thanks. Added to three more files. I think we have covered all the > cases where filtering can occur. >
Yes. The test looks good now. thanks Shveta
