Hi, I noticed that the log_error() utility function has a bug in its FRONTEND code path. The function uses fprintf() with a va_list argument, but fprintf() expects individual arguments. This should be vfprintf() instead.
The relevant code:
#else
fprintf(stderr, fmt, ap);
#endif
Should be:
#else
vfprintf(stderr, fmt, ap);
#endif
While this code path may not currently be compiled in practice, it would
cause compilation warnings or runtime crashes if the FRONTEND macro is ever
defined for files containing this function.
I've attached a patch that fixes this issue.
Bryan Green
0001-Fix-incorrect-fprintf-usage-in-log_error-FRONTEND-pa.patch
Description: Binary data
