On Thu, Oct 9, 2025 at 1:31 PM Chao Li <[email protected]> wrote: > > > > On Oct 8, 2025, at 14:29, Peter Smith <[email protected]> wrote: > > Perhaps that 2nd log was once supposed to say "created" (past tense), > but even that seemed redundant. > > Here is a small patch to remove the log duplication by keeping only > the log *within* the function. > > Thoughts? > > ====== > Kind Regards, > Peter Smith. > Fujitsu Asutralia > <v1-0001-remove-duplicate-logging-for-slot-creation.patch> > > > The change is straightforward, especially I like the second change of adding > “on publisher”, which makes the message clearer. >
Thanks. > For dry-run mode, I see in setup_recovery(), it debug-logs a message with “# > dry run mode recovery_target_lsn = xxx”, I think it would be good to add > similar debug logs in create_logical_replication_slot(), create_publication() > and drop_publication(). > Yes, I am already attempting to address those other dry-run logging issues in another thread [1]. ====== [1] https://www.postgresql.org/message-id/CAHut%2BPu84M8tgTjn%2B%2B4WCTETOX%3DNR4YmLn-%2B4B29UJeDTgoJ9Q%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia
