On Sep 29 2025, at 8:51 pm, Michael Paquier <[email protected]> wrote:

> On Tue, Sep 30, 2025 at 01:19:05PM +1300, David Rowley wrote:
>> NULL is a valid Bitmapset, so I don't really see the need to check for
>> an empty set before calling bms_free().  If those were removed, then
>> you'd not have to care about the coverage of that line.

Good point, I agree.  Thanks for reporting/reviewing David.

> Yeah, we could just remove them as you are suggesting, as well.
> --
> Michael

Thank you both, patch attached.

best.

-greg

Attachment: v1-0001-Don-t-check-for-NULL-before-calling-bms_free-in-t.patch
Description: Binary data

Reply via email to