Hello, I have reviewed this patch before and provided a number of comments that have been addressed by Akshay (so I encourage you to list my name and this address in a Reviewed-by trailer line in the commit message). One thing I had not noticed is that while this function has a "pretty" flag, it doesn't use it to pass anything to pg_get_expr_worker()'s prettyFlags argument, and I think it should -- probably just
prettyFlags = GET_PRETTY_FLAGS(pretty); same as pg_get_querydef() does. Thanks -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
